cockroachdb / cockroachdb/cockroach
contention: do not log failure to decode sql key errors
Open
A-cluster-observability
C-bug
E-quick-win
T-observability
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Currently in `getContentionEventInfo` we log an error message when we fail to decode a key. This was more for. informative purposes and is not intended to indicate any real issue with the contention information, rather just that it's possible to experience contention on non-sql keys. Instead of logging an error which can be a red herring we should either silently fail or indicate the failure to decode with more details on the UI.
[Slack thread](https://cockroachlabs.slack.com/archives/CHVV403F0/p1691699788409789).
Jira issue: CRDB-30519
Contributor guide
Assessment
This issue has not been assessed yet.