cockroachdb / cockroachdb/cockroach
kvserver: noisy snapshot reservation error logging
Open
A-kv-distribution
C-bug
E-starter
O-support
P-3
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
When many nodes are trying to send snapshots to a node at the same time (e.g. a new node in a cluster with dozens of nodes), many of the snapshot reservations will time out while they're queueing, logging messages like:
```
error sending couldn't accept ... giving up during snapshot reservation due to "kv.snapshot_receiver.reservation_queue_timeout_fraction": context deadline exceeded
```
We should either make sure these don't time out (such that the sender will wait its turn until the snapshot goes through), or avoid logging these errors which are benign and expected in cases like this.
Related to #103879, cc @AlexTalks.
Jira issue: CRDB-30505
Epic CRDB-58158
Contributor guide
Assessment
This issue has not been assessed yet.