cockroachdb / cockroachdb/cockroach

kvserver: eager lease preference enforcement occasionally fails when acquiring node fails liveness

Open
#108,512 0 comments 0 reactions 0 assignees View on GitHub
A-kv-distribution C-bug T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

https://github.com/cockroachdb/cockroach/pull/107507 added lease transfers when the acquiring node violated preferences. The mechanism can fail however, if the acquiring node then fails a heartbeat, like we saw in https://github.com/cockroachdb/cockroach/issues/108425.

**To Reproduce**

See the `lease-preferences/full-first-preference-down` roachtest: https://github.com/cockroachdb/cockroach/issues/108425.

**Expected behavior**

When (if) a node successfully heartbeats, the leases would transfer then. Or be acquired by another node.

**Environment:**
- CockroachDB version: 23.1

Jira issue: CRDB-30503

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.