cockroachdb / cockroachdb/cockroach

catalog: add validation for remaining tabledesc fields

Open
#108,449 2 comments 0 reactions 0 assignees View on GitHub
A-schema-catalog C-enhancement T-sql-foundations
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The following test shows that some fields are missing validation: https://github.com/cockroachdb/cockroach/blob/6aa46154a922a5dfdabb3e5f8f1ae990d645ada1/pkg/sql/catalog/tabledesc/validate_test.go#L57-L72

- [ ] UnexposedParentSchemaID
- [ ] NextMutationID
- [ ] ViewQuery
- [ ] SequenceOpts
- [ ] ReplacementOf
- [ ] CompositeColumnIDs
- [ ] DefaultExpr
- [ ] UsesSequenceIds
- [ ] OwnsSequenceIds
- [ ] PGAttributeNum
- [x] OriginColumnIDs
- [x] ReferencedColumnIDs

Jira issue: CRDB-30477

Epic CRDB-30352

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.