cockroachdb / cockroachdb/cockroach
sql: tests in `schema_changer_test.go` should also test with declarative schema changer whenever it can
Open
A-testing
C-enhancement
db-cy-23
T-sql-foundations
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
There a bunch of tests in `schema_changer_test.go` has declarative schema changer off explicitly. This is inadequate if we want to use legacy schema changer as a ground truth for declarative schema changer. Ideally we want to test with both legacy and declarative schema changer whenever we can. It's very likely that some behavior cannot be tested in declarative schema changer. But it worth a revisit on the test file.
Jira issue: CRDB-30304
Epic CRDB-31472
Contributor guide
Assessment
This issue has not been assessed yet.