cockroachdb / cockroachdb/cockroach

workload: handle ambiguous errors

Open
#107,571 3 comments 0 reactions 0 assignees View on GitHub
A-testeng-foundations A-testing C-bug T-testeng
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Clients are expected to handle ambiguous errors; for instance, see our own documentation:

* [cockroachlabs.com/docs/stable/transaction-retry-error-reference](https://www.cockroachlabs.com/docs/stable/transaction-retry-error-reference)
* [cockroachlabs.com/docs/stable/common-errors#result-is-ambiguous](https://www.cockroachlabs.com/docs/stable/common-errors#result-is-ambiguous)

Despite that, our very own `workload` does not handle these errors, leading to occasional roachtest failures that should not have happened.

We want `workload` to be able to handle these errors whenever possible (retrying when safe to do so). It might not be possible to completely eliminate these errors from bubbling up to the caller every time; each workload should be updated independently.

Jira issue: CRDB-30113

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.