cockroachdb / cockroachdb/cockroach

changefeedccl: run schema tests under both schema changers

Open
#107,532 2 comments 0 reactions 0 assignees View on GitHub
A-cdc C-enhancement quality-friday T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

At the moment, we run some tests only under the legacy schema changer (which will soon be moved over to the new, declarative schema changer https://github.com/cockroachdb/cockroach/issues/106906) or only under the declarative schema changer.

Ideally, we should metamorphically decide which schema changer tests run under. The declarative schema changer is enabled in production, so we should probably use it 90% of the time.

This is a little bit tricky because some tests need to change their assertions when changing schema changers (see https://github.com/cockroachdb/cockroach/pull/107184). In this case, it would be ideal to bifurcate those tests.

Jira issue: CRDB-30099

Epic CRDB-9179

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.