cockroachdb / cockroachdb/cockroach

allocator: implement output buffering to reduce frequent log.VEvent calls

Open
#107,421 0 comments 0 reactions 0 assignees View on GitHub
A-kv-distribution C-enhancement T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Is your feature request related to a problem? Please describe.**

When investigating delays in an allocator simulator test, we notice that a
significant amount of time were spent on `log.VEventf`. The issue originates
from `rankedCandidateListForRebalancing ` repeatedly calling
`IsStoreReadyForRoutineReplicaTransfer ` on all stores that pass
`StoreFilterThrottled `. As a short term mitigation, we removed the
`log.VEventf` for less interesting cases where store are alive. However, this
could indicate a prevalent issue.

A longer term strategy is to delve into different sections of the allocator code
and implement output buffering at a higher level to reduce frequency of
`log.VEventf`calls.

Jira issue: CRDB-30033

Epic CRDB-54646

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.