cockroachdb / cockroachdb/cockroach

teamcity: improve UX of diagnosing package timeouts

Open
#107,339 1 comment 0 reactions 0 assignees View on GitHub
C-enhancement quality-friday T-dev-inf
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

This is what it takes today:

https://github.com/cockroachdb/cockroach/assets/5076964/a636499f-e7ba-4ccf-b434-5b1fca8c8056

I can't imagine many people can do this sequence of clicks. I've had to do it quite a few times over the last couple of days. It keeps coming up. How can we improve the UX around package timeouts? Problems I see:

- test output doesn't indicate when the test has been running for a long time -> maybe we can put something into `log.Scope` or `leaktest` to call `t.Logf("test has been running for X minutes")` for each minute test has been running. This helps distinguish two kinds of problems (test timeout too short for how long the tests in the pkg shard take in aggregate vs single test gets stuck/is verrrry slow). Not distinguishing them can lead to filing issues against tests that are not to blame.
- finding the failing shard requires knowing that you need to search the build log for `FAIL:`, can we somehow make the shard available in each test output? If it's in the env we could just `t.Logf("shard: %d", ...)` from leaktest or log.Scope to capture most tests.

Jira issue: CRDB-29997

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.