cockroachdb / cockroachdb/cockroach

server: SpanStats architectural improvements

Open
#107,217 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Originally mentioned in #103957, I'm making a separate issue for these comments, so that 103957 can be closed.

- the “new” code for the stats-for-span function is deeply embedded in the obs API server, which is architecturally unsound since the functionality is a pure KV function and should be usable from SQL without interfacing with the API server at all.
- we want to have a version of this code that is guaranteed to operate on a consistent view of the entire span (i.e. not a mix of cached data for part of the span, and uncached for another part)
- we want the API to be able to reuse an existing client.Txn object (instead of synthetisizing its own)

Jira issue: CRDB-29949

Epic CRDB-25476

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.