cockroachdb / cockroachdb/cockroach

c2c: cross-cluster replication view in DB Console is visible to non-admins

Open
#106,360 1 comment 0 reactions 0 assignees View on GitHub
A-disaster-recovery C-bug T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

The ‘Cross-cluster replication’ screen is visible to non-admins. (The navigation is correctly removed.)

**To Reproduce**

- Log in as admin.
- Navigate to Metrics → Cross-cluster replication
- Revoke admin rights on user
- Reload the above DB Console page
- The metrics still display, though the navigation shows blank

**Expected behavior**

The page should show an error message indicating insufficient rights, as other pages around the DB Console do for non-admins.

In fact, I don’t think we should hide the nav item in the pull-down at all. Users should be allowed to navigate to it (know it exists) but get an error message.

**Environment:**
v23.1.5
Mac Intel
Install via homebrew

Jira issue: CRDB-29527

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.