cockroachdb / cockroachdb/cockroach

stress: slow pkgs don't get stressed for even 1 iter

Open
#106,346 2 comments 0 reactions 0 assignees View on GitHub
A-testeng-foundations T-testeng
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

See https://github.com/cockroachdb/cockroach/issues/101894#issuecomment-1624346881

For packages whose tests are slow / fall over under stress, we sometimes spend an entire hour but don't get through a single iteration of the pkg. In such cases, the test runner aborts. So we don't get the full benefit of stressing.

We should at least surface such cases. There are two obvious changes we can consider: fail such tests and the owning team(s) need to break them down so that they can get through one iteration. Or, run at least one interation anyway, even if it takes, say, 8h. If a pkg exceeds that, though, we are likely going to have to fall back to the first suggestion, so maybe that is the better one in the first place.

Jira issue: CRDB-29519

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.