cockroachdb / cockroachdb/cockroach

roachprod: parse machine architecture and use for validation

Open
#105,472 1 comment 0 reactions 0 assignees View on GitHub
A-testeng-infra A-testing C-enhancement E-quick-win T-testeng
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

After adding support for arm64 [1], CPU architecture is specified during cluster creation. However, `List` isn't parsing the architecture from cloud providers. Instead, we _optionally_ set a custom tag [3], when `create --arch` is used. The custom tag isn't required, hence we can't rely on it for validation. Instead, we should parse the architecture from a cloud provider.

[1] https://github.com/cockroachdb/cockroach/pull/103243
[2] https://github.com/cockroachdb/cockroach/blob/759387d935baa193e5309d00419682baadc4d8f9/pkg/roachprod/vm/vm.go#L59

Jira issue: CRDB-29062

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.