cockroachdb / cockroachdb/cockroach

bazel: refine stamping behavior further

Open
#105,377 0 comments 0 reactions 0 assignees View on GitHub
A-build-system C-enhancement T-dev-inf
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Since #97944, `dev` builds no longer `--stamp` by default, and now we only `--stamp` for `--cross` builds. This is better than the previous behavior, but still not ideal: we should really only be stamping if we're building a binary that needs to be stamped. AFAIK, this is only the `cockroach` executables (including `short`, `oss`, etc.) Stamping can still be skipped for `dev` builds.

Epic: CRDB-17171

Jira issue: CRDB-29005

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.