cockroachdb / cockroachdb/cockroach
FileSSTSink.write doesn't handle out of order revisions of the same key
Open
A-disaster-recovery
C-bug
T-disaster-recovery
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
`FileSSTSink`'s `write()` will return an error if we write different time chunks of the revision history for the same key out of order. In order prevent this type of error we need to add some logic to handle out of order timestamps in addition to out of order keys. See a reproduction in a unit test: https://github.com/cockroachdb/cockroach/pull/105368/files#diff-adb9e2addda473faae0afe0c778740d31d59f0bc41bfc304d117d216c5c3481fR228-R239
Jira issue: CRDB-29004
Contributor guide
Assessment
This issue has not been assessed yet.