cockroachdb / cockroachdb/cockroach
scbuild: finish migrating off deprecated scpb.ForEach*/Find*
Open
A-schema-changer-impl
C-cleanup
T-sql-foundations
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
in `scbuild` we have way too many assertion failures because our grammar for reasoning about elements there is not expressive enough and so we end up peppering the code with assertion failures when doing things like searching for a primary index element when processing an ALTER TABLE: we _know_ it's always there but we guard against the remote possibility that it's not. It makes for verbose, inexpressive and buggy code.
Jira issue: CRDB-28979
Epic CRDB-60938
Contributor guide
Assessment
This issue has not been assessed yet.