cockroachdb / cockroachdb/cockroach

cdc, cloud: warn on unrecognized sink params

Open
#104,630 2 comments 0 reactions 0 assignees View on GitHub
A-cdc C-enhancement T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

By design, if we get a query parameter on an https sink (cloud storage, webhook, etc.) that doesn't have significance in this context we transparently forward it. This can be confusing if the query param was meant to be significant. For example, `'webhook-https://localhost:3000?insecure_tsl_skip_verify=true'` has a typo, "tsl" for "tls", that results in the param not having its intended effect, but no error.

We have at least two channels where we could warn on unrecognized params: pgnotice and error hints. We should do one or both of these:

```
NOTICE: Unrecognized param(s) insecure_tsl_skip_verify are interpreted as part of the URL.
```

```
retryable error: Post "https://localhost:3000?insecure_tsl_skip_verify=true": dial tcp [::1]:3000: connect: connection refused
HINT: The param(s) insecure_tsl_skip_verify were not recognized query params and were interpreted as part of the URL.
```

Jira issue: CRDB-28645

Epic CRDB-28844

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.