cockroachdb / cockroachdb/cockroach

sql: reenable decimal in query-comparison-oracle

Open
#103,337 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement T-sql-queries
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The decimal type was disabled in query-comparison-oracle due to https://github.com/cockroachdb/cockroach/issues/88547. We were discussing in a collab session that it would improve our test coverage to reenable this type. We looked through some of the old issues and think that the errors may have to do with decimal precision due to the presence of division operators in the queries, however this will require some more investigation.

Jira issue: CRDB-27952

Contributor guide

Open the contributing guide

Research direction

Locate the query-comparison-oracle test and inspect the change that disabled decimal because of issue 88547. Run the relevant comparison tests, investigate whether division causes decimal-precision errors, and consider the work done when decimal is reenabled with the test coverage passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, sql
Domain
databases, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.