cockroachdb / cockroachdb/cockroach

cdc: move changefeed options logic from encoders to cdcevent pkg

Open
#103,309 2 comments 0 reactions 0 assignees View on GitHub
A-cdc C-bug T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

As seen in https://github.com/cockroachdb/cockroach/issues/103129, we do not support certain options for parquet. The reason is that every time we add a new format, you need to add code to the encoder to support them. These options are not encoder-specific, so we should remove the need to write code for them in each encoder. It would be much better to write the logic once in the `cdcevent` package - it should be a simple matter of tacking on extra columns to the events before they are sent to the encoders.

The list of columns which can be handled by the cdc event descriptor are
- [ ] updated
- [ ] mvcc_timestamp
- [ ] diff
- [ ] key in value
- [ ] topic in value
- [ ] resolved

Jira issue: CRDB-27937

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.