cockroachdb / cockroachdb/cockroach
build: verify runtime reported version matches publication name
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Currently it is possible for an artifact to be published by `make and publish build` using a version name that differs from what the binary would report as its version at runtime. We call `cockroach version` during `Make and publish build` but do not compare its output to the `VersionStr` or the `Build ID` printed in TC logs for use when a nightly is required.
We should add an assertion that the version string reported from `cockroach version` actually matches the value of `VersionStr` that is used to publish the artifact before publication, and thus also the value of `Build ID` printed out which is used by those looking to deploy a custom build.
Jira issue: CRDB-27222
Contributor guide
Assessment
This issue has not been assessed yet.