cockroachdb / cockroachdb/cockroach

server: use liveness instead of status record during upgrade checks

Open
#101,637 1 comment 0 reactions 0 assignees View on GitHub
C-bug O-support P-3 T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The cluster upgrade checks use node status records rather than liveness records to determine cluster membership. This is problematic with clusters from before 20.2, since node decommissioning in those versions simply deleted the liveness record (but not the status record), and so upgrades to 21.1 and beyond will fail since it believes these nodes are still cluster members.

This needs to check against the liveness record instead. We'll have to backport this all the way back to 21.1 to allow such clusters to upgrade to recent versions.

https://github.com/cockroachdb/cockroach/blob/75a55015e83f7e5ff3b2c3c7ee5201f5705414a1/pkg/server/auto_upgrade.go#L126-L134

Jira issue: CRDB-27080

Epic CRDB-27235

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.