cockroachdb / cockroachdb/cockroach

backupccl: zone config for system tables not included in backup are not restored

Open
#100,852 1 comment 0 reactions 0 assignees View on GitHub
A-disaster-recovery C-bug T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

If a backup is taken on a cluster where there is a custom GC TTL applied to a system table that is not included in backups, the custom TTL will not be present when the backup is restored. This can be specially problematic as it makes upgrade migrations such as the one introduced in #100141 ineffective; when the database is restored, the custom TTL will no longer apply (the corresponding row in `system.zones` will not exist) and that could lead to degraded observability performance for reasons that might be hard to diagnose.

### Reproduction

This behavior was first identified by running the `backup/mixed-version` roachtest in #100755. However, it can be readily observed by running `TestFullClusterBackup` and disabling the `SkipZoneConfigBootstrap` testing knob in [1].

[1] https://github.com/cockroachdb/cockroach/blob/7d219406b9c0fc5079403840d55ba40f721512f9/pkg/ccl/backupccl/utils_test.go#L105-L107

Jira issue: CRDB-26652

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.