cockroachdb / cockroachdb/cockroach

sqlstats: don't collect internal stmt stats if `sql.stats.response.show_internal.enabled` is off

Open
#100,767 0 comments 0 reactions 0 assignees View on GitHub
A-cluster-observability C-enhancement T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Currently we have the `sql.stats.response.show_internal.enabled` cluster setting that is off by default. This setting controls whether or not we surface internal stmts in console requests.

We should determine whether or not we'd like to turn off collecting internal stmt stats in our sqlstats system if this is disabled. Doing so would allow for more storage space for user queries and allow for faster page load times when querying from sql stats.

Jira issue: CRDB-26612

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.