cockroachdb / cockroachdb/cockroach

roachprod: output start and end timestamp to ssh logs

Open
#100,151 3 comments 0 reactions 0 assignees View on GitHub
A-testeng-infra C-enhancement quality-friday T-testeng
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

We currently preserve ssh debug logs in the case of any failure, however there is no way to see what time the command actually ran. The timestamp encoded in the log file currently, only indicates when the command was initialised, not when it was executed.

There is no easy way to show timestamps alongside the debug log output. A process substitution solution worked in bash, but not zsh. Additionally, it relies on enriching the existing error output of the command, on which some parts of the code may already depend.[1]

A compromise would be to emit start and end timestamps to the ssh debug file, which operates outside of stdout/stderr.

[1] A subset of read accesses of `RunResultDetails.Stderr` image

Jira issue: CRDB-26277

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.