cockroachdb / cockroachdb/cockroach-go

Use `stable` variable name instead `nonStable`

Open
#185 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
169
Forks
78
PR merge metrics
No merged PRs in 30d

Description

Having the variable be `nonStable` instead of `stable` is a bit unintuitive. I think the fact that you need to add this clarification to the function comment here is evidence for this -- you need to be very careful to explain what the parameter does, when if it were just `stable bool`, then it would be obvious.

_Originally posted by @rickystewart in https://github.com/cockroachdb/cockroach-go/pull/184#discussion_r2164482171_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.