cockroachdb / cockroachdb/cockroach-go
ExecuteInTx does not honor context cancellation
Open
- Dominant language
- Go
- Stars
- 169
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Description
The retry loop in `ExecuteInTx` does not check ctx.Done to abort the retries if the context is cancelled.
Found while working on adding query cancellation in the crdb SQL shell.
cc @andreimatei @rafiss
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at ExecuteInTx and inspect its retry loop and context handling. Reproduce the cancellation path described while adding query cancellation in the crdb SQL shell, then verify that cancellation stops retries without changing the existing transaction behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100