cockroachdb / cockroachdb/apd

Loss of precision when round-tripping with float64

Open
#142 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
805
Forks
48
PR merge metrics
No merged PRs in 30d

Description

Given a high enough integer value, apd seems to lose precision after some round-trips:
```
package main

import (
"math/rand/v2"
"testing"

"github.com/cockroachdb/apd/v2"
)

func TestRoundTrip(t *testing.T) {
// This number is exactly representable as a float64:
f64 := float64(rand.Int64())

dec := apd.New(0, 0).SetInt64(int64(f64))

f64RT, err := dec.Float64()
if err != nil {
t.Fatalf("round-trip f64->dec->f64: %v", err)
}

if f64 != f64RT {
t.Fatalf("mismatched: expect %f; got %f", f64, f64RT)
}

dec2, err := apd.New(0, 0).SetFloat64(f64)
if err != nil {
t.Fatalf("round-trip f64->dec->f64->dec: %v", err)
}

if dec.Cmp(dec2) != 0 {
t.Fatalf("mismatched: expect %v; got %v", dec, dec2)
}
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.