cobbr / cobbr/Covenant

[Bug] Bridge Listener Socket Concurrency

Open
#138 5 comments 0 reactions 1 assignee Claimed by @cobbr View on GitHub
question
Dominant language
C#
Stars
4.7k
Forks
822
PR merge metrics
No merged PRs in 30d

Description

**Feature Request or Bug**
Bug

**Describe the feature request or bug**
Socket writes and read get called from multiple threads without locking, leading to garbled writes and reads after a number of grunts/tasks come online
**To Reproduce**
Try and use a bridge listener for a while
**Expected behavior**
Doesn't fai

**Solution**
Lock before writes/reads.
![image](https://user-images.githubusercontent.com/60417776/73583515-83a1b080-4447-11ea-9c99-b618c45a0500.png)

Also async BridgeConnector reads helps things
![image](https://user-images.githubusercontent.com/60417776/73583546-b055c800-4447-11ea-85fa-1231b16c319e.png)

I mangled the code too much to do a clean PR, but hopefully this issue helps others with C2Bridge issues.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.