coala / coala/git-url-parse

Versions > 1.2.0 break handling of branch name in URL

Open
#35 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
30
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Under version 1.2.0 I this URL which correctly specifies a branch, PROD, works fine:

```
In [1]: import giturlparse; giturlparse.parse('git+ssh://git@gitlab.my_dept.uw.edu/uwmydept/my_repo.git@PROD')
Out[1]: Parsed(pathname='/uwmydept/my_repo.git', protocols=['git', 'ssh'], protocol='ssh', href='git+ssh://git@gitlab.my_dept.uw.edu/uwmydept/my_repo.git@PROD', resource='gitlab.my_dept.uw.edu', user='git', port=None, name='my_repo', owner='uwmydept')
```

But under 1.2.1 or 1.2.2 it gets an error:

```
In [1]: import giturlparse; giturlparse.parse('git+ssh://git@gitlab.my_dept.uw.edu/uwmydept/my_repo.git@PROD')

.....

~/.virtualenvs/my_dir/lib/python3.6/site-packages/giturlparse/parser.py in parse(self)
102 else:
103 msg = "Invalid URL '{}'".format(self._url)
--> 104 raise ParserError(msg)
105
106 return Parsed(**d)

ParserError: Invalid URL 'git+ssh://git@gitlab.my_dept.uw.edu/uwmydept/my_repo.git@PROD'
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.