coala / coala/corobo

Make LabHub is_room_member a private function of the module

Open
#602 3 comments 0 reactions 1 assignee Claimed by @kumar1202 View on GitHub
difficulty/low importance/medium
Dominant language
Python
Stars
67
Forks
98
PR merge metrics
No merged PRs in 30d

Description

LabHub.is_room_member is unnecessarily a static method of the class.

It can be moved to a private function `_is_room_member` at the module level, and then the tests can be improved to remove the need to do special plugin mocking.

See https://github.com/coala/corobo/pull/572#discussion_r206302575 for context

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.