cnpem / cnpem/sophys-web

[QUA] Remove proposal check for dropdown and add hook to form

Open
#75 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
4
Forks
3
Avg merge
1d 20h
Merged PRs (30d)
8

Description

We discussed that checking the user proposal here doesn't really makes sense. I it would be a better practice to get the user proposal from the hook directly in the form component that uses it as a default value and let the submit validation do it's thing (and per form, we decide when we want to let the user change its value or not).

_Originally posted by @brnovasco in https://github.com/cnpem/sophys-web/pull/74#discussion_r3016179134_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the dropdown component, its proposal check, and the form component that uses it as a default value. Trace how the user proposal is currently obtained and validated; the work is done when the form gets it through a hook and submit validation remains responsible for acceptance.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.