cnpem / cnpem/sophys-common

Improve handling of `FilePath` inside `PimegaCam`

Open
#91 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
3
Avg merge
1d 22h
Merged PRs (30d)
3

Description

Making this an issue to better keep track of the discussion surrounding it.

> @flowln just a little update about the file_path discussion. I talked with @RafaelLyra8 and, at least in the cases of PNR and SPU, we need to set and validate the file path using components from `PimegaCam`, that is why I was not using (and didn't know about) this `HDF5PluginWithFileStore`. So maybe, it would be useful a component that already checks the file_path when we set it trough the `file_path` Component from the `PimegaCam` class.
Anyway, I'm extending myself in a discussion that was not meant to be happening in this PR kkkkkkk again so sorry for this, I'm still learning how to correctly contribute in the projects. Please, if you still have some thoughts about this topic, feel free to reach out! Thank you guys so much for the help.

_Originally posted by @joao-biondo in https://github.com/cnpem/sophys-common/issues/87#issuecomment-4270206235_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the linked discussion about `file_path`, then inspect the `PimegaCam` component and the role of `HDF5PluginWithFileStore`. Clarify the expected behavior for PNR and SPU, including how the path is set and validated; the work is done when that behavior is agreed and covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.