cnpem / cnpem/sophys-common

Make base crio class public and abstract away the logic

Open
#66 0 comments 0 reactions 0 assignees View on GitHub
breaking change enhancement
Dominant language
Python
Stars
5
Forks
3
Avg merge
1d 22h
Merged PRs (30d)
3

Description

At: https://github.com/cnpem/sophys-common/blob/4e4d7145a5a922d64e3b8c9d4967e430536eb80e/src/sophys/common/devices/crio.py#L19, our implementation consider the base class as private, we could make it public and remove the PVs from it, since it can be very useful to create multiple types of devices.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at src/sophys/common/devices/crio.py around line 19 and inspect how the current base class defines its PVs and device behavior. Compare the existing device implementations to determine the reusable public abstraction; done means the base class can support multiple device types without carrying device-specific PVs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.