cncf / cncf/xds

Go Bazel builds fail to find cel.dev/expr

Open
#97 5 comments 8 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
271
Forks
85
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/cncf/xds/pull/89 the cel.dev/expr based annotations were reintroduced. Unfortunately, there still seem to be issues when trying to use Bazel, Go and Gazelle together, and importing this module.

I've recently added a dependency on `github.com/cncf/xds/go/xds/type/matcher/v3` and updated my dependency on go-control-plane to pick up a bugfix (https://github.com/envoyproxy/go-control-plane/commit/77feb56c98e5450a45be4715c868cca909873553 ).

(I'm not sure my new dependency there matters, tbh. It's just very close and maybe adding confusion.)

This update to go-control-plane updated the version to this library, and thus picked up the cel.dev/expr change.

Now, my builds fail with:
ERROR: /private/var/tmp/_bazel_randerson/01ba2733315bf63f62b0e43c3a981a72/external/com_github_cncf_xds_go/xds/type/v3/BUILD.bazel:3:11: no such target '@dev_cel_expr//:expr': target 'expr' not declared in package '' defined by /private/var/tmp/_bazel_randerson/01ba2733315bf63f62b0e43c3a981a72/external/dev_cel_expr/BUILD.bazel (Tip: use `query "@dev_cel_expr//:*"` to see all the targets in that package) and referenced by '@com_github_cncf_xds_go//xds/type/v3:type'

The BUILD file there doesn't actually define any go libraries, so this isn't particularly surprising, but I don't think this commit is working as expected right now.

I'm not really sure if the problem is here or in cel.dev/expr, but ... well, debugging 3 layers of modules down is not fun.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.