cncf / cncf/xds

Consider tagging module "go"?

Open
#56 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
271
Forks
85
PR merge metrics
No merged PRs in 30d

Description

I found that go packages, say `github.com/cncf/xds/go/udpa/annotations`, are placed in submodule `github.com/cncf/xds/go`.

However, it seems that module `github.com/cncf/xds/go` is not tagged. According to [Go Modules wiki](https://github.com/golang/go/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository), submodule should be tagged like `relative-path-to-root/vX.X.X`.
At now, when trying to import package `github.com/cncf/xds/go/udpa/annotations`, downstream would depends on **pseudo-version** of module `github.com/cncf/xds/go`.
```
github.com/cncf/xds/go v0.0.0-20211001041855-01bcc9b48dfe
```
I think it is not very readable and difficult to upgrade. This is not conductive to version control either.
So, I propose whether it is possible to tag submodule properly to better support go users. For example, `go/v0.0.1`, `go/v1.0.0`etc, so that other project can use tag to import this module in go.mod.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.