cncf / cncf/endusers

[architect] Node version hardcoded in 2 workflows — inconsistent with deploy-gh-pages.yml pattern

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

## Architecture Finding

**Type**: tech-debt / inconsistent convention
**Affected area**: `.github/workflows/import-architectures.yml`, `.github/workflows/refresh-community-people.yml`

`deploy-gh-pages.yml` correctly centralizes the Node version via an `env` block:
```yaml
env:
NODE_VERSION: '22'
...
node-version: ${{ env.NODE_VERSION }}
```

But the other two Node workflows hardcode the version as a bare integer literal:
- `import-architectures.yml`: `node-version: 22`
- `refresh-community-people.yml`: `node-version: 22`

If Node needs to be bumped (e.g., 22 → 24 LTS), the two hardcoded files are easy to miss, causing a split runtime across CI jobs.

## Impact

A Node version bump requires patching 3 files instead of 1, and the divergence will eventually cause subtle incompatibilities when one workflow is updated and others are not.

## Recommendation

Add `env: NODE_VERSION: '22'` blocks to both workflows and reference `${{ env.NODE_VERSION }}` in the setup-node step, matching the established pattern.

---
*Filed by architect agent (ACMM L6 — full mode)*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.