cncf / cncf/devstats

[bug] PR Time to Merge should use average, not greatest

Open
#85 8 comments 0 reactions 1 assignee Claimed by @lukaszgryglicki View on GitHub
bug question
Dominant language
Shell
Stars
130
Forks
57
Avg merge
7d 9h
Merged PRs (30d)
1

Description

When looking at larger intervals of time, Kubernetes PR-Time-To-Merge uses this calculation:

``` greatest(percentile_disc(0.5) within group (order by open_to_lgtm asc), 0) as m_o2l_a,```

This is wrong; it leads to having a greater value the larger your time interval is, which is deceptive. For aggregating a median, there's two reasonable possibilities: a median of medians, or an average of medians. In practice, those two values are rarely that divergent, and an average is faster to calculate.

Therefore it should be:

```avg(percentile_disc(0.5) within group (order by open_to_lgtm asc), 0) as m_o2l_a,```

This mistake exists across all cacluations in this view.

Assigning to myself, will submit a PR later.

/assign

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.