`checkMaintainerInLFX` needs some re-thinking
Open
needs-kind
needs-triage
- Dominant language
- Go
- Stars
- 31
- Forks
- 36
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 70
Description
`maintainers.go:243` creates a bare `&http.Client{}` instead of using the validator's injected `pv.client`. This means:
- No timeout configured (could hang indefinitely on a slow/unresponsive LFX API)
- Can't be tested with `httptest` since the client isn't injectable
- Currently broken anyway due to no long-lived LFX token (TBD)
Contributor guide
Assessment
This issue has not been assessed yet.