cmu-delphi / cmu-delphi/github-deploy-repo

support minimize of modern js

Open
#16 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
0
Forks
2
PR merge metrics
No merged PRs in 30d

Description

There's an action to minimize javascript [using uglify-js](https://github.com/cmu-delphi/github-deploy-repo/blob/2c3e2f201fec7b96fa1e5412482b3ff510546d5b/src/actions/minimize_js.py#L22), which [only supports ES5](https://www.npmjs.com/package/uglify-js). We should use something that allows us to use more modern ES6, like maybe [terser](https://github.com/terser/terser). See this 2019 [comparison of minimizers](https://blog.logrocket.com/uglify-vs-babel-minify-vs-terser-a-mini-battle-royale/) for more info.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/actions/minimize_js.py at the existing uglify-js invocation and trace how the minimize action is run. Compare a modern JavaScript minimizer such as terser against the current ES5-only behavior, then verify that modern ES6 input is minimized successfully without breaking the deployment action.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
build-system, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.