cmu-delphi / cmu-delphi/forecast-eval
Remove, revise, or replace `start_dev` target
- Dominant language
- R
- Stars
- 6
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
The `start_dev` target is not useful. It runs bash inside a docker container, whic his easy enough to do by hand. It's also unclear which docker container it's actually trying to use.
The target runs the `ghcr.io/cmu-delphi/forecast-eval` image, which is meant for the dashboard, but mounts the `Report` and `dist` dirs that are only needed to run the pipeline, not the dashboard.
Three options here:
- Remove all `make` support for running `bash` in containers. Let devs do that themselves if they need to.
- Make `start_dev` run `bash` in the dashboard container only, i.e. drop pipeline dependencies. Set up another target to run `bash` in the pipeline `forecast-eval-build` image.
- Set up a variable that by default runs the dashboard or pipeline in their respective containers (`start_dashboard` and `score_forecast`), but can be overridden through the `make` call to run `bash` in each container.
Contributor guide
No contributing guide indexed for this repository
Research direction
Review the Make target definitions for start_dev, start_dashboard, and score_forecast, then compare the referenced dashboard image with the forecast-eval-build image and their mounted directories. Resolve which of the three stated approaches is intended, and consider the work done when the selected targets use clearly scoped containers without the current ambiguity.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bash, docker
- Domain
- build-system, devops
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100