cmu-delphi / cmu-delphi/forecast-eval

Makefile `r_build` target is sometimes used inappropriately

Open Beginner friendly
#280 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
R
Stars
6
Forks
3
PR merge metrics
No merged PRs in 30d

Description

In the [Makefile](https://github.com/cmu-delphi/forecast-eval/blob/f12ab6f303ba81d6cbc32d61720061474496a00f/Makefile), the `r_build` target is listed as a dependency of the [`score_forecast` target](https://github.com/cmu-delphi/forecast-eval/blob/f12ab6f303ba81d6cbc32d61720061474496a00f/Makefile#L24) and the contained `docker run` call does use the `forecast-eval-build` image created in `r_build` -- great. The `start_dev` target, on the other hand, has `r_build` as a dependency but uses an entirely different image. It looks like the `r_build` dependency is completely extraneous.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open the Makefile and inspect the start_dev and r_build targets, comparing start_dev's dependencies with the Docker image it uses. Confirm whether start_dev can run without invoking r_build, then verify that start_dev no longer triggers the unnecessary build step.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, r
Domain
build-system, devops
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.