cmu-delphi / cmu-delphi/exploration-tooling

`clear_lastminute_nas` will erase too much data as written for `chng`

Open
#103 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
2
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Currently, `clear_lastminute_nas` will remove any row which has any `NA`'s in it whatsoever. With multiple signals, this can mean removing rows with real data (as an example, see `11-29-24`, for which `10-02-24` is the last day with data). Before using `chng`, we will need another scheme to handle differently missing data. Ideas:

- locf `NA`'s in non-outcome signals. This is not a great idea, as lags likely become meaningless.
- do the equivalent of `extend_ahead` but for lags (e.g. if the last observation for chng is 30 days behind, adjust the lags of `c(0,7,14)` to `c(30,37,44)`.
- ?

@brookslogan may have other thoughts I forgot about.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.