cmu-delphi / cmu-delphi/epiprocess

`epi_cor` `shift_by` should use all non-`time_value` keys by default

Open
#151 1 comment 0 reactions 0 assignees View on GitHub
bug P2
Dominant language
R
Stars
12
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Currently `epi_cor` uses only the `geo_val` field by default for computing time shifts over. If an `epi_df` has any additional keys set, they should also be used by default in the `shift_by` arg to make sure time shifts are sensical. The `shift_by` default should have the meaning `setdiff(, "time_value")`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the `epi_cor` entry point and inspect how its default `shift_by` value is derived from `geo_val`. Check the behavior with an `epi_df` containing additional keys; done means the default uses every key except `time_value`, while an explicitly supplied `shift_by` remains respected.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.