cmu-delphi / cmu-delphi/epipredict

`min_train_window`, `quantile_by_key` args are not used

Open
#169 6 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
R
Stars
18
Forks
13
Avg merge
21d 58m
Merged PRs (30d)
1

Description

Grepping around, @dshemetov and I were unable to see `min_train_window` or `quantile_by_key` actually used by `arx_forecaster`, `arx_classifier`, `flatline_forecaster`, or any other forecaster I missed. We did find:
- There might be a PR for the `min_train_window` part; see comment [here](https://github.com/cmu-delphi/epipredict/blob/9a804303d97aa9d3de1323c66a52797acce86483/R/arx_forecaster.R#L56).
- `quantile_by_key` docs reference `layer_residual_quantiles()`' `by_key` parameter, but I can't see it actually being forwarded along.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.