cmu-delphi / cmu-delphi/DelphiRF

`revision_forecast()` and `cv_revision_forecast()` appear to "ignore" `training_days` when called directly

Open
#9 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

From a quick skim of source code for training window handling:

- `revision_forecast()` appears to use `training_days` only in filepath generation.
- (`DelphiRF()` does `training_days`-related filtering before calling `revision_forecast()`, so the `DelphiRF()` function's fine.)
- `cv_revision_forecast()` doesn't appear to do the `training_days`-related filtering before calling `revision_forecast()`, so it seems it actually won't respect `training_days` unless the user manually performs that filtering ahead of time.

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the implementations of `revision_forecast()`, `cv_revision_forecast()`, and `DelphiRF()` to trace where `training_days` filtering occurs. Compare the direct and cross-validation paths, then verify that both respect the requested training window, using any existing project checks for forecast behavior if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.