cmss13-devs / cmss13-devs/cmss13
ChemSim completely broke on us, possibly from finding chem with trait listed twice.
- Dominant language
- DM
- Stars
- 170
- Forks
- 940
- Avg merge
- 5d 16h
- Merged PRs (30d)
- 61
Description
## Testmerges
#8676: 'Tgui update 1' by Kashargul at commit ac0e520c52
#8770: 'Sorokyne Strata - Complete revamp - Begone Snow!' by Zenith00000 at commit b53d942e9f
#8624: 'Centralized Overwatch Console' by SpypigDev at commit 1d40b2a0f1
#8836: 'Refactors unleash_flame procs' by Nihisohel at commit 21664873ff
## Round ID
27079
## Description of the bug
We found a chemical (calupydol) with Neuroshielding listed twice. After unlocking it, interacting with NRS trait in the chemsim broke the trait and blocked it from being removed. It also started to replace other traits with the NRS label.
Lavender Lori was the one who actually dealt with it first, I'm just relaying what happened.
## What's the difference with what should have happened?
Traits shouldn't appear twice, and they shouldn't steal other traits' spaces in the chemsim.
## How do we reproduce this bug?
Unsure. This is my guess:
1: Scan a chem which erroneously has the same trait appear in it twice.
2: Try to add one or both(??) of the traits to a Created chemical.
3: The trait can no longer be interacted with, and switching categories (TOX, MED, etc.) will make it start replacing other traits.
## Attached logs
```
Analysis of Calupydol
Results for sample: #32
ID: Calupydol
Database Details:
The following information relating to Calupydol is restricted with a level 3 clearance classification.
Neuroshielding Level 1 - Protects the brain from neurological damage caused by toxins.
Pneumopeutic Level 3 - Mends the interstitium tissue of the alveoli restoring respiratory functions in the lungs.
Neuroshielding Level 1 - Protects the brain from neurological damage caused by toxins.
Oxidizing Level 3 - The chemical is oxidizing, increasing the intensity of chemical fires. However, the fuel is also burned slightly faster because of it.
Overdoses at: 25 units
Standard duration multiplier of 1x
Saved emission spectrum of Calupydol to the database.
Composition Details:
- 3 Mercury
- 1 Hot Sauce
- 1 Egg Plasma
Reaction would require the following catalysts:
- 5 Cherry Souto
```
## Additional details
- Author: WizardreousWalrus
- Admin: Detective Google
- Note: can be fixed in the immediate term by deleting and respawning the synthesizer
Contributor guide
Assessment
This issue has not been assessed yet.