cmss13-devs / cmss13-devs/cmss13
OT custom mortar and possibly other casings have problems with their fire behaviour.
- Dominant language
- DM
- Stars
- 170
- Forks
- 940
- Avg merge
- 5d 16h
- Merged PRs (30d)
- 61
Description
### Testmerges
#7242: 'WIP Yautja Clan TGUI Menu' by realforest2001 at commit 0f24fabd69 #7521: 'Human Resprites & Tweaks - Marines looking awesome' by Nanu308 at commit 15b7b83600 #7511: 'Weyland-Yutani Intranet Terminal' by realforest2001 at commit df2219bffb #7165: 'Fax Responders TestMerge Collection' by realforest2001 at commit e71f82bc11 #7623: 'More working/hazman joe lines' by Blundir at commit 6eb17a0017 #7335: 'gamemode value adjustmands, anti off screen and AP spam hvh' by cuberound at commit c986004509 #7548: 'Adds ability for admins to end round with a custom ending + upp ending icon' by Blundir at commit bd84103267 #6248: 'New Map: LV-759 Hybrisa Prospera' by Zenith00000 at commit cf2d6dfb19
### Round ID
24946
### Description of the bug
- Fire pattern was wrong for custom mortar, the pattern was the "star" while the fire intensity was under 30.
- Sometimes the range is not close to what the demolition scanner (possible that it could be showing wrong values and is the true culprit) shows. I think i noticed on one round the range of custom rocket fire range was actually one smaller then the scanner showed. This also happend with mortar casing when water (3 units) was added to reduce fire intensity, the intensity was reduced and range did not get reduced, at least that's what the demolition scannner showed, but in the demolitions simulator the pattern was still the star and the range was reduced by about 4 tiles.
### What's the difference with what should have happened?
- The pattern should be the full coverage while under or equal to 30 fire intensity, and should not still be the "star" one.
- The range should not change by things that dont have a range modifier such as water.
- The values that demolition scanner showed should match the actuall behaviour of the casing fire spread.
### How do we reproduce this bug?
1.Create a custom mortar shell (one used that produced the bug had the following - **60x2**lithium **60**methane **40**ethanol).
2.Scan the assembled mortar shell with the scanner and see that fire intensity is under 30.
3.Explode the shell in the demolitions simulator.
4.See that the pattern is still the star.
### Issue Bingo
- [X] Issue could be reproduced at least once
- [X] Issue happened in a recent (less than 7 days ago) round
- [X] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)
Contributor guide
Assessment
This issue has not been assessed yet.