cmss13-devs / cmss13-devs/cmss13

Not every item's update_icon() calls /obj/proc/update_icon(), but they should

Open
#1,676 3 comments 0 reactions 0 assignees View on GitHub
Consistency Issue Not a Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

## Testmerges:

## Description

During a PR review [Fira mentioned](https://github.com/cmss13-devs/cmss13/pull/1406#discussion_r1029811102) how various objects that use the `update_icon` proc should be calling `..()` to get to `/obj/proc/update_icon()` which handles stuff like acid overlay and similar effects. However, I know for a fact a number of items don't do that since often their `update_icon` conflicts with their parent's `update_icon` (like, say, Bluespace Beaker not wanting a reagent overlay from regular Beaker code). So I think we might need to do something about the `/obj/proc/update_icon()` not being called by various items and other things if we want to keep that functionality consistent.

## Difference between expected and actual behavior

Apparently every item should be deferring to `/obj/proc/update_icon()` in the end but they don't.

## Steps to reproduce

1) Check various pouches, containers that have fullness, or the Bluespace Beaker code

## Issue bingo (not required to be all checked)

- [x] Issue could be reproduced at least once
- [x] Issue happened in a recent (less than 7 days ago) round
- [x] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.