cmss13-devs / cmss13-devs/cmss13

Ticket panel falsely closing mhelps for disconnection

Open
#13,113 1 comment 0 reactions 0 assignees View on GitHub
Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

## Testmerges
#13027: 'Add Multi-Z handling to get_line' by MistChristmas at commit 7dee321554
#12985: 'Extending the MD ping animation' by Yachuk at commit c1891db738
#11128: '[code beet] dissolver (used to be venator)' by cuberound at commit 7b738da461
#10925: 'Cape River Mining Colony - Ground Map' by Steelpoint at commit 15dd70a12a
#12947: 'Revert "Working multiz tacmap, round two, extra buttons"' by Rain7x at commit ea384007a4

## Round ID
36279

## Description of the bug
Saw old Mhelp that didnt get any attention for an hour, saw that player was still connected by observing them. Went to answer, when clicking the claim/mark button on the ticket panel TGUI, it immediately responded with that the user was disconnected and archived it

## What's the difference with what should have happened?
Mhelps should only close on disconnection when player is actually disconnected

## How do we reproduce this bug?
1. Make Mhelp
2. ???
3. Mark Mhelp on ticket panel with said button
4. See error

## Attached logs
```
Mhelp #1 for the round listed above
```

## Additional details
- Author: Onetoughcreampuff
- Admin: Lagomorphica
- Note: None

Contributor guide

Open the contributing guide

Research direction

Reproduce the report in round 36279 using Mhelp #1: keep the player connected, then use the claim/mark button in the ticket panel TGUI. Trace the ticket panel's disconnection check and identify why a connected player is treated as disconnected. Done means marking a connected Mhelp no longer archives it as disconnected, while genuine disconnections still close it.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.