cmss13-devs / cmss13-devs/cmss13

You can go through holes in walls while resting

Open Beginner friendly
#13,086 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

### Testmerges

The following pull requests are currently test merged: #12537: 'Atlan Station - Groundmap' by oceany-a11y at commit 774eef601e #12618: 'Vanguard Passive Shield no longer regenerates when UNCONSCIOUS or INCAPACITATED, FLOORED, updated strain description.' by Venuska1117 at commit 813c96e27b #12947: 'Revert "Working multiz tacmap, round two, extra buttons"' by Rain7x at commit ea384007a4 #13027: 'Add Multi-Z handling to get_line' by MistChristmas at commit 7dee321554 #13032: 'Some Role Authority Cleanup' by Drulikar at commit e0b6b5312a #12985: 'Extending the MD ping animation' by Yachuk at commit c1891db738 #12633: 'Oppressor's abduct goes through xeno structures' by JHINgle4ce at commit becbc41ebd

### Round ID

36235

### Description of the bug

Just needs a simple check to see if the xeno is resting or not after attempting before putting them through the hole

good starter PR imho

`/obj/effect/acid_hole/MouseDrop_T(mob/M, mob/user)`

### What's the difference with what should have happened?

Resting xenos probably shouldnt be able to climb through acid holes. Movement is blocked when resting for xenos, Imho climbing through an acid hole counts as movement.

### How do we reproduce this bug?

1. be xenon
2. resting body on ground next to acid hole
3. teleport through wall after mousedropping self on hole

### Issue Bingo

- [x] Issue could be reproduced at least once
- [x] Issue happened in a recent (less than 7 days ago) round
- [x] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Contributor guide

Open the contributing guide

Research direction

Start at /obj/effect/acid_hole/MouseDrop_T(mob/M, mob/user) and read the surrounding checks for resting or movement-blocked xenos. Reproduce the reported self-drop through an acid hole, then verify that resting xenos remain blocked while non-resting xenos retain the expected climbing behavior.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.